Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=541589
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Lubomir Rintel lkundrak@v3.sk 2009-11-30 08:02:30 EDT --- Thanks for the fixes.
(In reply to comment #3)
(In reply to comment #2)
3.) You do not run the test suite Please do so, ideally in %check section. Seems like you'd need to add a dependency on hamcrest.
Test suite is failing for me and upstream build is a nightmare. I've submitted a few issues about that but no response yet. Hopefully this is not a blocker.
Sounds fair.
I'd also suggest replacing Summary with something more descriptive, (i.e. adding "database library" at the end or something like that).
Hmm, I'm not sure I understand what you want. I picked the first paragraph of sqljet.com assuming upstream devs will describe their work best.
That was just a suggestion, feel free to keep your Summary if you feel it's better; definitely not a blocker or anything.
APPROVED.