[Bug 719402] Review Request: OSGi-bundle-ant-task - A wrapper around Bnd to allow easy bundle creation from ant builds

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=719402

--- Comment #4 from Ankur Sinha  2011-07-17 13:47:49 EDT ---
Hello,

(In reply to comment #3)
> [x] MUST: The file containing the text of the license(s) for the package must
> be included in %doc.
>     Please add a license declaration file, which is available from here:
>     http://www.opensource.org/licenses/bsd-license.php

I extracted the license from the source java file into a separate file and
added it as a source.
> [+] MUST: The sources used to build the package must match the upstream source.
>     The commands to create the tarball don't work on my system. I've used the
>     following to checkout the appropriate svn revision:
> https://opensource.luminis.net/svn/BUNDLES/releases/build-plugin-0.2.0/
> tar -cvzf OSGi-bundle-ant-task.tar.gz build-plugin-0.2.0/
>
> $ md5sum *
> 17504d454b4d416fdb85ecf43df9ca3c  OSGi-bundle-ant-task.tar.gz
> 14d31b67b02eb26bfbfc2b3823f49961  OSGi-bundle-ant-task.tar.gz.packaged
>
> The checksums don't match. What could be the problem here?

I'm not sure, I redid an svn checkout and got another md5sum :/

[ankur@ankur dump]$ md5sum OSGi-bundle-ant-task.tar.gz
~/rpmbuild/SOURCES/OSGi-bundle-ant-task.tar.gz
dbae4046553508212cbf4d75b943a859  OSGi-bundle-ant-task.tar.gz
14d31b67b02eb26bfbfc2b3823f49961 
/home/ankur/rpmbuild/SOURCES/OSGi-bundle-ant-task.tar.gz

BTW, I missed a space in the command. It's meant to be:
# svn export
https://opensource.luminis.net/svn/BUNDLES/releases/build-plugin-0.2.0/ 
OSGi-bundle-ant-task

I assure you that the directories are same, only the generated tars are
different, which is causing the difference in checksum.

[ankur@ankur dump]$ diff -ur OSGi-bundle-ant-task/
~/rpmbuild/SOURCES/OSGi-bundle-ant-task.orig/
[ankur@ankur dump]$ diff OSGi-bundle-ant-task.tar.gz
~/rpmbuild/SOURCES/OSGi-bundle-ant-task.tar.gz
Binary files OSGi-bundle-ant-task.tar.gz and
/home/ankur/rpmbuild/SOURCES/OSGi-bundle-ant-task.tar.gz differ

http://ankursinha.fedorapeople.org/OSGi-bundle-ant-task/OSGi-bundle-ant-task...

http://ankursinha.fedorapeople.org/OSGi-bundle-ant-task/OSGi-bundle-ant-task...

* Sun Jul 17 2011 Ankur Sinha <ankursinha AT fedoraproject DOT org> -
0.2.0-0.3.svn1242
- correct versioning
- correct svn command
- add license

Thanks,
Ankur