Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513541
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #1 from Fabian Affolter fabian@bernewireless.net 2009-07-24 03:24:44 EDT --- Just some quick comments on your spec file:
You wrote in your sec file... ----%>------ #The source on sourceforge does not use autotools. Source1 does Source0: http://downloads.sourceforge.net/project/cpulimit/cpulimit/cpulimit/cpulimit... Source1: http://ashay.info/rpm/cpulimit-1.1.tar.gz ----<%------
Have you make a patch for the usage of autotools? If yes, send this patch upstream and apply the patch in the spec file.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:...
There are more details available about 'Source0'
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Spec_file_pieces... look for 'Source0'
- 'Source0' seems to be wrong, shouldn't it be 'http://downloads.sourceforge.net/cpulimit/%%7Bname%7D-%%7Bversion%7D.tar.gz' ?
- For valid groups you can use 'less /usr/share/doc/rpm-*/GROUPS'
- %attr (-,root,root) can be left away, it sufficient only to use %{_mandir}/*/*
- Isn't rpmlint complaining about the line length of the %description?