https://bugzilla.redhat.com/show_bug.cgi?id=2181036
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Status|NEW |POST
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Non-blocking request for improvement:
The crate includes a few files that are not really necessary:
- the "/img/" folder - the files "/CODEOWNERS", "/coverage_config.json", "/coverage_config_x86_64.json"
Consider adding the following setting to the [package] table in Cargo.toml:
``` exclude = [ "/img/", "/CODEOWNERS", "/coverage_config.json", "/coverage_config_x86_64.json", ] ```
===
Other than that:
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0 OR BSD-3-Clause) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches