Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-propel_generator - An Object Relational Mapping (ORM) framework for PHP5
https://bugzilla.redhat.com/show_bug.cgi?id=433045
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2008-07-03 23:38 EST ------- Since you fixed this package up with the changes from the propel_runtime review, I might as well take care of it as well.
All rpmlint has to complain about is the lack of documentation, which is fine.
* source files match upstream: f8f5d1743defa37c08b6c28122a02c03a082ed25edc6e14c15026cd8fac68fa6 propel_generator-1.3.0RC1.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: php-pear(pear.phpdb.org/propel_generator) = 1.3.0 php-pear-propel_generator = 1.3.0-0.2.rc1.fc10 = /bin/sh /usr/bin/pear php-channel(pear.phpdb.org) php-cli >= 5.2.0 php-dom php-pdo php-pear php-pear-phing >= 2.3.0 php-xml php-xsl
* %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content.
APPROVED