Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543689
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mschwendt@gmail.com AssignedTo|nobody@fedoraproject.org |mschwendt@gmail.com Flag| |fedora-review+
--- Comment #3 from Michael Schwendt mschwendt@gmail.com 2010-06-24 08:08:50 EDT --- * Correct Source URL would be: http://www.openfabrics.org/downloads/libipathverbs/libipathverbs-1.2.tar.gz
$ sha1sum libipathverbs-1.2.tar.gz 462c07f85b4d568ef72846865ee48ba0af4bb015 libipathverbs-1.2.tar.gz
Provides: %{name}-devel = %{version}-%{release}
Nowadays, automatic package name "Provides" would also add a second target-specific Provides for %{?_isa}, so also adding that one to explicit Provides would make sense:
%if "no%{?_isa}" != "no" Provides: %{name}-devel%{_isa} = %{version}-%{release} %endif
* openSUSE also build the package for 32-bit and only "ExcludeArch: s390 s390x". A .spec comment explaining your "ExlusiveArch: x86_64" would be helpful.
The spec file included in the tarball is not excluding x86 either. But it may be mistaken, since it also marks /etc/libibverbs.d/ipath.driver as %config, which you've said would be incorrect.
* Verified:
$ repoquery --whatprovides /etc/libibverbs.d libibverbs-0:1.1.3-4.fc13.i686 libibverbs-0:1.1.3-4.fc13.x86_64
Directory meanwhile is owned correctly by libiverbs.
* ldconfig calls not needed. They would be useless due to the chosen driver library SONAME.
* Placement of the static driver lib in a separate -static subpackage follows the packaging guidelines.
* There are three other libibverbs-driver packages, which are packaged in the same way. Things mentioned in this comment could be fixed in fedora pkg cvs, so:
APPROVED