Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: abcmusiex - Training music score (pentagram) reading
https://bugzilla.redhat.com/show_bug.cgi?id=427010
------- Additional Comments From rodolfo.alcazar@padep.org.bo 2007-12-30 07:50 EST ------- Jason, thanks a Lot, I really appreciate your fast answer.
For my part, I'm not really interested in the software but if the packager of abcMIDI is willing to co-maintain this package with you (and you fix the below packaging issues) then I'm willing to sponsor you. Are you in contact with him?
No. But I wrote seymour.shlien@crc.ca and Gérard Milmeister gemi@bluewin.ch, who I think is the abcMIDI packager. I hope they'll give me a hand.
As for this package, it looks mostly OK, but I have a few comments and questions:
Thanks. Here are my replies:
... don't understand "%(echo $HOME)/%{name}/RPMS/" in the spec ...
Fixed.
BuildRoot: should be "%{_tmppath}..."
Fixed.
Souce0: should be the full URL to the tarball, probably something like: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....
Fixed.
... %{_bindir}/abcmusiex in your %files list instead of using /usr/bin.
Fixed.
Even though you call the configure script properly, your makefile doesn't call gcc with any flags.
Well, it's very simple, no flags needed.
You should package the NEWS file as %doc.
Fixed.
The sourceforge page says that this program requires abc2prt and abcm2ps but neither of them is provided by the dependencies of this package.
Oops! A webpage error. Just needs the packages mentioned in the .spec file. Webpage fixed.
So, all corrections are included in the last package I've uploaded minutes ago. (rpmlint runs fine on these): http://internap.dl.sourceforge.net/sourceforge/abcmusiex/abcmusiex-0.9-4.fc8...
Thanks again, I'll let you know of any answer from the abcMIDI packager/mantainers. Or else I'll search for another co-mantainer.
Happy newyear!