Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475065
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #25 from Jussi Lehtola jussi.lehtola@iki.fi 2009-09-08 05:21:23 EDT --- (In reply to comment #24)
Since you've already done a good job bringing this package in shape, there isn't much left to do. If nobody else wants to do the re-review, I can do it later today. However, I'm not quite happy with the call of exit() in a shared library. This is simply bad style and should be avoided by all means. I'm not sure about Fedora's policy about this, though. Here is a patch that replaces the call of exit() by throwing an exception: http://mgieseki.fedorapeople.org/givaro/givaro-exit.patch
Calling exit() is not forbidden (in fact it is quite common in scientific packages), so you can omit the rpmlint warning. You should not apply any patches that make functional changes, since that will break compatibility with upstream. You can ask upstream to make the change, though...