https://bugzilla.redhat.com/show_bug.cgi?id=2297189
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- No need to be sorry - sometimes this is too easy to miss. It might be good to have rust2rpm print a warning in this case, that the generated spec file has FIXME items in it that need to be addressed.
===
Package looks good to me now. I see that you're also trimming the Summary to be within expected length limits, you can also make this permanent with a rust2rpm.toml setting:
``` [package] summary = "Attribute for generating "open" fieldless enums that accept any integer value" cargo-install-bin = false ```
Don't forget to also commit the rust2rpm.toml file you have to dist-git on import, it's only useful if kept around :)
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)