Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497686
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@gmail.com AssignedTo|nobody@fedoraproject.org |iarnell@gmail.com Flag| |fedora-review+
--- Comment #1 from Iain Arnell iarnell@gmail.com 2009-04-26 04:44:15 EDT --- + source files match upstream. 54cc46c5e670796ebd2134f83b0d8a346bfb447c Archive-RPM-0.04.tar.gz
+ package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. LGPLv2+
+ license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1321073
+ package installs properly. + rpmlint has no complaints: perl-Archive-RPM.noarch: I: checking perl-Archive-RPM.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane: perl(Archive::RPM) = 0.04 perl(Archive::RPM::ChangeLogEntry) = 0.04 perl-Archive-RPM = 0.04-1.fc12
= cpio perl(:MODULE_COMPAT_5.10.0) perl(Archive::RPM::ChangeLogEntry) perl(DateTime) perl(English) perl(File::Temp) perl(Moose) perl(MooseX::AttributeHelpers) perl(MooseX::Types::DateTimeX) perl(MooseX::Types::Path::Class) perl(Path::Class) perl(RPM2) >= 0.67 perl(namespace::clean) perl(overload) rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass. t/00-load.t ........... ok t/100-archive-rpm.t ... ok t/101-archive-srpm.t .. ok t/102-changelog.t ..... ok All tests successful. Files=4, Tests=28, 5 wallclock secs ( 0.05 usr 0.01 sys + 4.67 cusr 0.49 csys = 5.22 CPU) Result: PASS
+ no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package.
APPROVED