[Bug 598553] Review Request: perl-PPIx-Regexp

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598553

Iain Arnell <iarnell(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Iain Arnell <iarnell(a)gmail.com&gt; 2010-06-06 03:56:26 EDT ---
+ source files match upstream.  
    e1e2bfa7502ee3d606adb80753090712  PPIx-Regexp-0.007.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2233176

+ package installs properly.
+ rpmlint has no complaints:
    perl-PPIx-Regexp.noarch: I: checking
    perl-PPIx-Regexp.noarch: I: checking-url
http://search.cpan.org/dist/PPIx-Regexp/ (timeout 10 seconds)
    perl-PPIx-Regexp.src: I: checking
    perl-PPIx-Regexp.src: I: checking-url
http://search.cpan.org/dist/PPIx-Regexp/ (timeout 10 seconds)
    perl-PPIx-Regexp.src: I: checking-url
http://www.cpan.org/authors/id/W/WY/WYANT/PPIx-Regexp-0.007.tar.gz (timeout 10
seconds)
    2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(PPIx::Regexp) = 0.007
    perl-PPIx-Regexp = 0.007-1.fc14
    perl(PPIx::Regexp::Constant) = 0.007
    perl(PPIx::Regexp::Dumper) = 0.007
    perl(PPIx::Regexp::Element) = 0.007
    perl(PPIx::Regexp::Lexer) = 0.007
    perl(PPIx::Regexp::Node) = 0.007
    perl(PPIx::Regexp::Node::Range) = 0.007
    perl(PPIx::Regexp::Structure) = 0.007
    perl(PPIx::Regexp::Structure::Assertion) = 0.007
    perl(PPIx::Regexp::Structure::BranchReset) = 0.007
    perl(PPIx::Regexp::Structure::Capture) = 0.007
    perl(PPIx::Regexp::Structure::CharClass) = 0.007
    perl(PPIx::Regexp::Structure::Code) = 0.007
    perl(PPIx::Regexp::Structure::Main) = 0.007
    perl(PPIx::Regexp::Structure::Modifier) = 0.007
    perl(PPIx::Regexp::Structure::NamedCapture) = 0.007
    perl(PPIx::Regexp::Structure::Quantifier) = 0.007
    perl(PPIx::Regexp::Structure::Regexp) = 0.007
    perl(PPIx::Regexp::Structure::Replacement) = 0.007
    perl(PPIx::Regexp::Structure::Subexpression) = 0.007
    perl(PPIx::Regexp::Structure::Switch) = 0.007
    perl(PPIx::Regexp::Structure::Unknown) = 0.007
    perl(PPIx::Regexp::Support) = 0.007
    perl(PPIx::Regexp::Token) = 0.007
    perl(PPIx::Regexp::Token::Assertion) = 0.007
    perl(PPIx::Regexp::Token::Backreference) = 0.007
    perl(PPIx::Regexp::Token::Backtrack) = 0.007
    perl(PPIx::Regexp::Token::CharClass) = 0.007
    perl(PPIx::Regexp::Token::CharClass::POSIX) = 0.007
    perl(PPIx::Regexp::Token::CharClass::Simple) = 0.007
    perl(PPIx::Regexp::Token::Code) = 0.007
    perl(PPIx::Regexp::Token::Comment) = 0.007
    perl(PPIx::Regexp::Token::Condition) = 0.007
    perl(PPIx::Regexp::Token::Control) = 0.007
    perl(PPIx::Regexp::Token::Delimiter) = 0.007
    perl(PPIx::Regexp::Token::Greediness) = 0.007
    perl(PPIx::Regexp::Token::GroupType) = 0.007
    perl(PPIx::Regexp::Token::GroupType::Assertion) = 0.007
    perl(PPIx::Regexp::Token::GroupType::BranchReset) = 0.007
    perl(PPIx::Regexp::Token::GroupType::Code) = 0.007
    perl(PPIx::Regexp::Token::GroupType::Modifier) = 0.007
    perl(PPIx::Regexp::Token::GroupType::NamedCapture) = 0.007
    perl(PPIx::Regexp::Token::GroupType::Subexpression) = 0.007
    perl(PPIx::Regexp::Token::GroupType::Switch) = 0.007
    perl(PPIx::Regexp::Token::Interpolation) = 0.007
    perl(PPIx::Regexp::Tokenizer) = 0.007
    perl(PPIx::Regexp::Token::Literal) = 0.007
    perl(PPIx::Regexp::Token::Modifier) = 0.007
    perl(PPIx::Regexp::Token::Operator) = 0.007
    perl(PPIx::Regexp::Token::Quantifier) = 0.007
    perl(PPIx::Regexp::Token::Recursion) = 0.007
    perl(PPIx::Regexp::Token::Reference) = 0.007
    perl(PPIx::Regexp::Token::Structure) = 0.007
    perl(PPIx::Regexp::Token::Unknown) = 0.007
    perl(PPIx::Regexp::Token::Unmatched) = 0.007
    perl(PPIx::Regexp::Token::Whitespace) = 0.007
=
    perl >= 0:5.006
    perl(base)  
    perl(Carp)  
    perl(List::MoreUtils)  
    perl(List::MoreUtils)  
    perl(List::Util)  
    perl(:MODULE_COMPAT_5.10.1)  
    perl(Params::Util) >= 0.025
    perl(Params::Util) >= 0.25
    perl(Params::Util) >= 0.25
    perl(PPI::Document)  
    perl(PPI::Document)  
    perl(PPIx::Regexp)  
    perl(PPIx::Regexp::Constant)  
    perl(PPIx::Regexp::Lexer)  
    perl(PPIx::Regexp::Node::Range)  
    perl(PPIx::Regexp::Structure)  
    perl(PPIx::Regexp::Structure::Assertion)  
    perl(PPIx::Regexp::Structure::BranchReset)  
    perl(PPIx::Regexp::Structure::Capture)  
    perl(PPIx::Regexp::Structure::CharClass)  
    perl(PPIx::Regexp::Structure::Code)  
    perl(PPIx::Regexp::Structure::Main)  
    perl(PPIx::Regexp::Structure::Modifier)  
    perl(PPIx::Regexp::Structure::NamedCapture)  
    perl(PPIx::Regexp::Structure::Quantifier)  
    perl(PPIx::Regexp::Structure::Regexp)  
    perl(PPIx::Regexp::Structure::Replacement)  
    perl(PPIx::Regexp::Structure::Subexpression)  
    perl(PPIx::Regexp::Structure::Switch)  
    perl(PPIx::Regexp::Structure::Unknown)  
    perl(PPIx::Regexp::Token::Assertion)  
    perl(PPIx::Regexp::Token::Backreference)  
    perl(PPIx::Regexp::Token::Backtrack)  
    perl(PPIx::Regexp::Token::CharClass::POSIX)  
    perl(PPIx::Regexp::Token::CharClass::Simple)  
    perl(PPIx::Regexp::Token::Code)  
    perl(PPIx::Regexp::Token::Comment)  
    perl(PPIx::Regexp::Token::Condition)  
    perl(PPIx::Regexp::Token::Control)  
    perl(PPIx::Regexp::Token::Delimiter)  
    perl(PPIx::Regexp::Token::Greediness)  
    perl(PPIx::Regexp::Token::GroupType::Assertion)  
    perl(PPIx::Regexp::Token::GroupType::BranchReset)  
    perl(PPIx::Regexp::Token::GroupType::Code)  
    perl(PPIx::Regexp::Token::GroupType::Modifier)  
    perl(PPIx::Regexp::Token::GroupType::NamedCapture)  
    perl(PPIx::Regexp::Token::GroupType::Subexpression)  
    perl(PPIx::Regexp::Token::GroupType::Switch)  
    perl(PPIx::Regexp::Token::Interpolation)  
    perl(PPIx::Regexp::Tokenizer)  
    perl(PPIx::Regexp::Token::Literal)  
    perl(PPIx::Regexp::Token::Modifier)  
    perl(PPIx::Regexp::Token::Operator)  
    perl(PPIx::Regexp::Token::Quantifier)  
    perl(PPIx::Regexp::Token::Recursion)  
    perl(PPIx::Regexp::Token::Structure)  
    perl(PPIx::Regexp::Token::Unknown)  
    perl(PPIx::Regexp::Token::Unmatched)  
    perl(PPIx::Regexp::Token::Whitespace)  
    perl(Readonly)  
    perl(Readonly)  
    perl(Scalar::Util)  
    perl(strict)  
    perl(Task::Weaken)  

+ %check is present and all tests pass.
    + ./Build test
    t/basic.t .. ok
    t/parse.t .. ok
    t/unit.t ... ok
    All tests successful.
    Files=3, Tests=6358,  3 wallclock secs ( 0.89 usr  0.07 sys +  1.88 cusr 
0.08 csys =  2.92 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

You could remove these explicit requires from the spec as they're picked up
automatically.
perl(List::MoreUtils)  
perl(Params::Util) >= 0.25
perl(PPI::Document)  
perl(Readonly)  

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.