Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xblast - Lay bombs and Blast the other players of the field (SDL version)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229476
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-24 12:11 EST ------- Well,
A. First for xblast-2.10.4-1:
* File dependency - Writing the package which provides the file is recommended expect you have somewhat strong reason to write file dependency (for vera font). Please check: http://fedoraproject.org/wiki/PackagingDrafts/FileDeps (This is a draft)
* Source URL - Please use http://downloads.sourceforge.net/<package_name>/XXXX.tar.gz if it is possible. Please check: http://fedoraproject.org/wiki/PackagingDrafts/SourceUrl (This is a draft). - Please specify the URL of xblast.png if possible.
* Timestamps ---------------------------------------------------------- install -m 755 %{SOURCE3} $RPM_BUILD_ROOT%{_bindir}/%{name} ---------------------------------------------------------- - This is only a wrapper script and keeping timestamp (i.e. install -p) is recommended.
* Documentation - Perhaps the following files can be used. ---------------------------------------------------------- ./xblast.man ----------------------------------------------------------
* Functionality - xblast-x11 cannot be launched for me. ---------------------------------------------------------- [tasaka1@localhost xblast]$ xblast-x11 could not load font 24 could not load font 18 could not load font 14 X Error of failed request: BadFont (invalid Font parameter) Major opcode of failed request: 56 (X_ChangeGC) Resource id in failed request: 0x800010 Serial number of failed request: 519 Current serial number in output stream: 541 -----------------------------------------------------------
* Directory/file ownership - Well as the build log says: ----------------------------------------------------------- -DGAME_DATADIR="/usr/share/xblast" ----------------------------------------------------------- I think that %{_datadir}/xblast should be owned by xblast-common, not by xblast-data because xblast requires that the files are installed under %{_datadir}/xblast.
- And currently the location of gettext mo files are not correct because build log says: ----------------------------------------------------------- -DLOCALEDIR="/usr/share/xblast/locale" ----------------------------------------------------------- This should be moved to %{_datadir}/locale (well, some messages are corrupted on both fr_FR and de_DE, perhaps due to ISO-8859 style vs UTF-8 style).