Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459871
--- Comment #6 from Rakesh Pandit rakesh.pandit@gmail.com 2008-09-03 09:22:55 EDT ---
[ APPROVED ]
rpmlint is clean
rp => rpmlint [rakesh@thulsadoom SRPMS]$ rp samefile-2.12-2.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[rakesh@thulsadoom x86_64]$ rp samefile-2.12-2.fc10.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[rakesh@thulsadoom x86_64]$ rp samefile-debuginfo-2.12-2.fc10.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Required: [x] Name (in accordance guidelines) [x] spec file name [x] License approved by fedora [x] Spec file is in American Eng and legible [x] Build successfully [x] BuildRequires okay [x] Duplicate files - nil [NA] locale [x] permissions -- okay [x] source link correct [x] packaging guidlines [x] Buildroot correct [x] owns every directory it creates [x] file encoding - checked [x] package has no dependency on files in %doc [NA] gui [x] No dependencies outside FHS guidelines [!] Source0 URL is wrong. It should be http://www.schweikhardt.net/%%7Bname%7D-%%7Bversion%7D.tar.gz . Without www it does not work. [x] md5sum
Source from srpm: [rakesh@thulsadoom x86_64]$ md5sum samefile-2.12.tar.gz 5e51411512f693897f9cfd59c45071f7 Using Source0 as http://www.schweikhardt.net/%%7Bname%7D-%%7Bversion%7D.tar.gz [rakesh@thulsadoom samefile]$ md5sum samefile-2.12.tar.gz 5e51411512f693897f9cfd59c45071f7
md5sum matches
[x] unnecessary files excluded [x] native compiler test [NA] devel package contains right files
Optional suggestions: [!] request upstream to include license file. [!] Include ChangeLog (it has important info)
*You may like to ignore them*
Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated
Please correct URL before importing. You may also like to look at optional suggestions.