Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: ctags
https://bugzilla.redhat.com/show_bug.cgi?id=225669
than@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?
------- Additional Comments From than@redhat.com 2008-02-15 11:26 EST -------
Comment:
- fix utf-8 with iconv(1)
fixed
- Both Summary and description should be reworked, they don't match the
package as of today.
what is the problem here? could you please give more infos?
- guidelines
- changelog is 10 years old (sic!), could be a be shorter?
the old changelog should be remained
- disttag is missing
it's fixed
- source url is wrong, see:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6e...
it's fixed
- I prefer this buildroot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
i prefer %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- add %{?_smp_mflags} to make
fixed
- preserve timestamp on man files (cp -p/install -p)
fixed
- don't use %makeinstall
fixed
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0...
- don't shiop INSTALL
the rest seems ok.
fixed
- License: ok
- American English: ok, however as noted the summary and description is
outdated and should be fixed.
any idea how to fix it?
Then a issue maybe outside the scope of this review, I really like to see etags enabled and included. Perhaps in a ctags-etags subpackage like this:
it doesn't make sense to add redundant etags here. wont fix
i built new ctags-5.7 in rawhide. could you please check again. Thanks