[Bug 2117112] Review Request: python-zope-hookable - Efficient creation of hookable objects

https://bugzilla.redhat.com/show_bug.cgi?id=2117112

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Miro Hrončok  ---
Further feedback, as I was the original reviewer for bz2090791 but then got cut
off by Nick without involving me here :(
> rm -rf src/%{name}.egg-info

This is most likely not needed and should not be in the spec file just because
some older packages have it.
> Source0:        %{pypi_source}

Using %{pypi_source} without the name argument is deprecated.
> URL:            https://pypi.python.org/pypi/%%7Bpypi_name%7D

Two things here:

1. the URL cannot be copied from the spec and pasted to a browser, which is
not nice for a packager who has the spec in front of them and need to go to the
website
 2. upstream lists http://github.com/zopefoundation/zope.hookable as their
website, not PyPI and I belive we should use the same URL as upstream
> Summary:        Efficient creation of hookable objects

The second summary could be DRY'ed by using:

Summary:    %{summary}

The big %if/%else between EPEL and Fedora could use a few empty lines around
the %else statement to make it clearer it's not part of the %install section.
> -k "not test_pure_python"

This could use an explanation in a comment.
> %{buildroot}/%{python3_sitearch}/zope/hookable

This is unusual after %pytet --pyargs. Is it indeed needed? What about plain
zope.hookable here?

And finally, my favorite:
> %global pypi_name zope.hookable

Is this worth having just for the 3 usages in the spec when everywhere else we
need to use zope-hookable or zope/hookable anyway?