[Bug 210007] Review Request: libtune - standard API to access the kernel tunables

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtune - standard API to access the kernel tunables

https://bugzilla.redhat.com/show_bug.cgi?id=210007

------- Additional Comments From [e-mail]  2007-08-31 09:54 EST -------
(In reply to comment #33)
> variables:
>
> The %{distro_string} is used too.
> Since it is built from the %{family} and %{release} variables, we can say they
> are all used.

ok
> base_kernel:
>
> uname -r would give me something like "2.6.21-1.3194.fc7", while I only need the
> first 3 fields of it: "2.6.21"

ok, but you don't need the --whatprovides 
rpm -q --queryformat='%{VERSION}' kernel-headers should be enough
also buildrequire kernel-headers for this
> kernel required:
>
> Don't need to require the exact kernel, since several releases are supported,
> starting from 2.6.9. Actually, I want to avoid changing my spec file each time
> the kernel changes. That's why I'm extracting the running kernel release.

ok
> Licensing:
>
> Fixed - But rpmlint should be fixed accordingly: it is now telling me my License
> string is invalid. May be there was another version released after license
> guidelines has changed?

yes rpmlint got updated
=> rpmlint-0.80-3.fc7 should know about the new license tags.
> dot
>
> Whish one are you talking about?
> Couldn't find anything about dots in
>
> http://fedoraproject.org/wiki/Packaging/Guidelines#head-ef67b32cfe3903b0aaab...

sry confused the summary with the description this is ok.
> distro_string:
>
> I actually only changed it in the tunables-distro-data description.
> The problem is that anyewhere else, the "FC7" string is used instead of f7. So I
> would have to change things upstream.
> But if it is really a problem, please tell me and I'll do the changes, since I
> am the upstream.

%dist should be fc7 (fedora collection 7) so you should be fine there or did I
miss anything? btw this is only a cosmetic change.
> SPEC URL: http://www.bullopensource.org/libtune/libtune-0.12-4/libtune.spec
> SRPM URL:
> http://www.bullopensource.org/libtune/libtune-0.12-4/libtune-0.12-4.fc7.src....

-----------

The package fails to build here:
   SYMLINK include/base -> include/basedbs/base-2.6.22.4
Version 2.6.22.4 is not supported
is it because of the .4 ? 
if yes use 
rpm -q --queryformat='%{VERSION}' kernel-headers | cut -c 0-6
to get the kernel version.
I tested this and it complains about kernel 2.6.22 not supported.