https://bugzilla.redhat.com/show_bug.cgi?id=1058163
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #11 from Rex Dieter rdieter@math.unl.edu --- sources: ok 739859cf57d4c8a23452c43e84f66e56 glmark2-2014.03.tar.gz
13. SHOULD use better appdata validation, current best practice is to:
and use %if 0%{?fedora} > 19 BuildRequires: libappstream-glib %endif and %check appstream-util validate-relax --nonet %{buildroot}%{_datadir}/appdata/%{name}.appdata.xml ||:
you can omit the conditional, if you're already intending to target f20+
but that's not a blocker, and the rest looks great to me now, APPROVED.