Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtkmozembedmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193106
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |kevin@tummy.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From kevin@tummy.com 2006-09-02 02:35 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: See below - Package compiles and builds on at least one arch. See below - BuildRequires correct See below - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. See below - Package doesn't own any directories other packages own. See below - No rpmlint output.
SHOULD Items: OK - Should include License or ask upstream to include it. See below - Should build in mock.
Issues:
1. Source's don't match from upstream: 2e15fa5ac91ee0d8434d79fb0bb2badd gtkmozembedmm-1.4.2.tar.gz d4233234e0af148764cb59d578f101fd gtkmozembedmm-1.4.2.tar.gz.1
2. Is this package targeted for fc5 only? devel/rawhide/fc6 doesn't have mozilla-devel.
3. The URL doesn't seem to mention this library at all: URL: http://gtkmm.sourceforge.net/ Is there a more approprate one?
4. Since ldconfg is the only command you are running in the post and postun, you might change them to '%post -p /sbin/ldconfig' and '%postun -p /sbin/ldconfig'
5. Might not include the useless INSTALL and perhaps you should include the TODO file.
6. It doesn't seem to want to build here in mock for fc5: + ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu -- target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share -- includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec -- localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/ usr/share/info --disable-static --enable-docs configure: error: cannot find install-sh or install.sh in scripts ./scripts error: Bad exit status from /var/tmp/rpm-tmp.22962 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.22962 (%build)