Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=677693
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Petr Pisar ppisar@redhat.com 2011-02-16 03:11:19 EST --- Spec file changes: --- tintin.spec 2011-02-15 18:26:41.000000000 +0100 +++ tintin.spec.1 2011-02-15 19:15:50.000000000 +0100 @@ -1,6 +1,6 @@ Name: tintin Version: 2.00.5 -Release: 2%{?dist} +Release: 3%{?dist} Summary: TinTin++, aka tt++, is a free MUD client Group: Applications/Internet License: GPLv2+ @@ -43,6 +43,7 @@ chmod 644 SCRIPTS chmod 644 docs/* && mv -v docs/* . chmod 644 mods/*.mods && mv -v mods/*.mods . +iconv -f latin1 -t utf8 igr.mods > igr.mods.utf8 && mv igr.mods.utf8 igr.mods
%files %defattr(-,root,root,-) @@ -57,6 +58,9 @@ %doc SCRIPTS
%changelog +* Tue Feb 15 2011 Petr Sabata psabata@redhat.com - 2.00.5-3 +- igr.mods now gets converted to proper utf8 + * Tue Feb 15 2011 Petr Sabata psabata@redhat.com - 2.00.5-2 - Source corrected - Description spelling corrected
FIX: Convert igr.mods into UTF-8.
+iconv -f latin1 -t utf8 igr.mods > igr.mods.utf8 && mv igr.mods.utf8 igr.mods Ok.
$ rpmlint tintin.spec ../SRPMS/tintin-2.00.5-3.fc14.src.rpm ../RPMS/x86_64/tintin-2.00.5-3.fc14.x86_64.rpm ../RPMS/noarch/tintin-doc-2.00.5-3.fc14.noarch.rpm tintin.src: W: spelling-error Summary(en_US) tt -> rt, tr, t tintin.src: W: spelling-error %description -l en_US tt -> rt, tr, t tintin.x86_64: W: spelling-error Summary(en_US) tt -> rt, tr, t tintin.x86_64: W: spelling-error %description -l en_US tt -> rt, tr, t tintin.x86_64: W: no-manual-page-for-binary tt++ tintin-doc.noarch: W: spelling-error %description -l en_US tt -> rt, tr, t 3 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint Ok.
Package builds in F16 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2843512). Ok.
Package is in line with Fedora packaging guidelines.
Resolution: Package APPROVED.