[Bug 701183] Review Request: perl-CGI-Application-Plugin-RateLimit - Limits runmode call rate per user

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=701183

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Petr Pisar  2011-05-16 06:34:44 EDT ---
Spec file changes:

--- perl-CGI-Application-Plugin-RateLimit.spec 2011-05-01 23:46:44.000000000
+0200
+++ perl-CGI-Application-Plugin-RateLimit.spec.1 2011-05-14 22:58:18.000000000
+0200
@@ -1,6 +1,6 @@
 Name:           perl-CGI-Application-Plugin-RateLimit
 Version:        1.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Limits runmode call rate per user
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -9,10 +9,13 @@
 BuildArch:      noarch
 BuildRequires:  perl(CGI)
 BuildRequires:  perl(CGI::Application)
-BuildRequires:  perl(Class::Accessor)
+BuildRequires:  perl(Class::Accessor::Fast)
 BuildRequires:  perl(DBD::SQLite)
+BuildRequires:  perl(DBI)
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Temp)
 BuildRequires:  perl(Test::More)
+Requires:       perl(CGI::Application)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

%{?perl_default_filter}
@@ -31,7 +34,6 @@
 make %{?_smp_mflags}

%install
-rm -rf $RPM_BUILD_ROOT

make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT

@@ -45,11 +47,13 @@

%files
-%defattr(-,root,root,-)
 %doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*

%changelog
+* Sat May 14 2011 Emmanuel Seyman  - 1.0-2
+- Clean up spec as per package review (#701183)
+
 * Thu Nov 25 2010 Emmanuel Seyman  1.0-1
 - Specfile autogenerated by cpanspec 1.78.
> FIX: BuildRequire on perl(Class::Accessor::Fast) instead of
> perl(Class::Accessor) as Class::Accessor::Fast is used in code
> (RateLimit.pm:26)

-BuildRequires:  perl(Class::Accessor)
+BuildRequires:  perl(Class::Accessor::Fast)
Ok.
> FIX: BuildRequire perl(DBI) because of tests (t/02simple.t:15)

+BuildRequires:  perl(DBI)
Ok.
> FIX: BuildRequire perl(File::Temp) because of tests (t/02simple.t:16)

+BuildRequires:  perl(File::Temp)
Ok.
> TODO: Remove obsolete BuildRoot cleaning in %install section.

-rm -rf $RPM_BUILD_ROOT
Ok.
> TODO: Remove already implicit %defattr in %files section.

-%defattr(-,root,root,-)
Ok.
> Done (first I've heard of this)

It's news
(https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions).
> FIX: Require perl(Class::Accessor::Fast) explicitly as it's not discovered by
> rpmbuild (RateLimit.pm:26)

$ rpm -q --requires -p
../RPMS/noarch/perl-CGI-Application-Plugin-RateLimit-1.0-2.fc16.noarch.rpm 
|sort |uniq -c
      1 perl >= 0:5.006
      1 perl(base)  
      1 perl(Carp)  
      1 perl(CGI::Application)  
      1 perl(Class::Accessor::Fast)  
      1 perl(:MODULE_COMPAT_5.12.3)  
      1 perl(strict)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Fixed in F16 dependency generator. Ok.
> TODO: Require perl(CGI::Application) explicitly as this module is extension
> for that class.

+Requires:       perl(CGI::Application)
Ok.

Package builds in koji
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3073704). Ok.

Resolution: Package APPROVED.