Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kmobiletools
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130
michael@knox.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |michael@knox.net.nz OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From michael@knox.net.nz 2006-07-21 04:48 EST ------- Hello.. I will review this package for you..
----------------------------------------
Review for release 2:
* RPM name is OK * Source kmobiletools-0.4.3.3.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK
Needs work: * Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets) * Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets)
Package looks pretty good. If you fix up the %post/%postun scriplets, I can approve this submission.