Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-hearts - Game of Hearts implementation for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=291741
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-11-23 10:50 EST
-------
Some comments:
* I guess copying them from config.{guess,sub} from %_datadir/libtool
is sufficient for "sh bootstrap" (and this work for me).
(BR: libtool is needed)
* Don't use "make install-strip". Stripping binaries by yourself
disables debuginfo rpm creation.
* Please use %find_lang, desktop-file-install (BR: desktop-file-utils
needed)
(In reply to comment #32)
One thing to note, though, is that the original source package had a
Make target
of install-desktopDATA which uses "install" to copy the .desktop file. Should
this be removed from upstream? From the packages? Or be left alone? Would it
make sense for upstream to use desktop-file-install? Or should that target just
be removed?
I don't think there is any reason upstream should change the
behavior about
installing desktop file.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.