Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694287
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #52 from Hans de Goede hdegoede@redhat.com 2011-04-28 04:31:25 EDT --- Hi,
(In reply to comment #51)
Everything looks good. The debuginfo file now has some size to it :)
New spec and SRC RPM uploaded.
SRC RPM: https://docs.google.com/leaf?id=0B4A6of0Rl4nUY2UxZGQ4ZDEtY2Q5MC00MTNmLWExOTE...
SPEC: https://docs.google.com/leaf?id=0B4A6of0Rl4nUZWVlOWE3ZGEtNDdiMi00MWZmLWE5NmQ...
Looks good now, approved!
One last small thing, but that can be fixed before / after import into git, you copy pasted the Summary for the doc subpackage from the devel doc package and did not adjust it to describe the doc subpackage.
So since this package is approved now it is time to sponsor you, next I'll need to know your FAS account username to create one if needed, see: http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account
Then I'll add you to the packagers group and sponsor you.
Regards,
Hans