Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: lxpanel - A lightweight X11 desktop panel
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219930
------- Additional Comments From fedora@deadbabylon.de 2007-01-08 15:08 EST ------- (In reply to comment #7)
OK - rpmlint -i lxpanel-0.2.4-3.src.rpm W: lxpanel non-coherent-filename lxpanel-0.2.4-3.src.rpm The file which contains the package should be named <NAME>-<VERSION>-<RELEASE>.<ARCH>.rpm.
Mhh. Strange. I can't remember which .rpmmacros I have used for this package. So I've uploaded a new version which is the result of the mock build. Could you test it for this issue (just to play safe this time)?
First part is a BSD like license, second GPLv2. OK - Since GPL is more restrictive than BSD the whole package becomes GPL. So the license field in the spec is ok.
The GPL is also the license at gnomefiles.org: http://www.gnomefiles.org/app.php/LXPanel
MINOR NOTE - line warps in long fields like %description are usually done
after
79 characters.
Fixed.
MINOR NOTE - Instead of %dir %{_datadir}/lxpanel/ %{_datadir}/lxpanel/* %dir %{_libdir}/lxpanel/ %{_libdir}/lxpanel/* you could simply use %{_datadir}/lxpanel/ %{_libdir}/lxpanel/
Ok. Fixed.
OK - IMO no desktop file is needed since it's panel and not what I call a typical program/standalone application.
Also think so. gnome-panel and kicker also have no desktop file.
OK - lxpanel works fine, but lxpanelctl is buggy. I can't add more starter because the "Select Application"-Dialog doesn't list the files in /usr/share/applications. Also hitting return in the location bar doesn't
work.
Looking at src/plugins/launchbar.c I think this is a known issue (see the
FIXME
in line 490) and isn't really meant to work atm.
You're right. Seems to be already filed as a bug: http://sourceforge.net/tracker/index.php?func=detail&aid=1623222&gro...
SPEC Url: http://deadbabylon.de/fedora/extras/lxpanel/lxpanel.spec SRPM Url: http://deadbabylon.de/fedora/extras/lxpanel/lxpanel-0.2.4-4.fc6.src.rpm
Changelog: * Mon Jan 08 2007 Sebastian Vahl fedora@deadbabylon.de - 0.2.4-4 - Fixed some minor issues from the review process (#219930)