[Bug 1809097] Review Request: php-marcusschwarz-lesserphp - a LESS compiler written in PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1809097

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Obsoletes is wrong: php-lessphp-0.5.0-11.fc32 is the latest, so you need
something like
Obsoletes: php-lessphp < 0.5.0+0

Including the version in the spec file name seems wrong.

+ package name is OK (please rename the spec file)
+ latest version
+ license is acceptable (MIT (or GPLv3))
+ license is specified correctly
+ build and installs OK
+ fedora-review and rpmlint seem happy
+ Provides/Requires/BuildRequires look OK

rpmlint says:
E: description-line-too-long C It is designed to be compatible with less.js
(https://lesscss.org/), and suitable
→ please wrap.

php-marcusschwarz-lesserphp.src:65: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 65)

$ /usr/bin/plessc
PHP Fatal error:  Uncaught Error: Class 'lessc' not found in /usr/bin/plessc:47
Stack trace:
#0 {main}
  thrown in /usr/bin/plessc on line 47
→ that doesn't seem right :(