[Bug 1256435] Review Request: metapixel - photomosaic generator

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256435

--- Comment #1 from Miroslav Suchý  ---
> %define _bindir /usr/bin
> %define _mandir /usr/share/man

Why? Those macros are used even on RHEL5.
> rm -rf $RPM_BUILD_ROOT

a) this should be at the beggining of %install and not prep, b) not necessary
unless you target EPEL

Use macros consitently. I.e. %{buildroot} instead of $RPM_BUILD_ROOT.
> gzip $RPM_BUILD_ROOT/%{_mandir}/man1/metapixel.1

Not necessary. rpm will compress it automatically. Actually rpm can use even
different compress format e.g. xz
Therefore
  %files
  %{_mandir}/man1/metapixel.1.gz
should be rather
  %files
  %{_mandir}/man1/metapixel.1*
> rm -rf %{buildroot}
> %defattr(-, root, root)

Both not needed unless you target EPEL

- Dist tag must be present.

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Side note, this package already exist in dist-git, but is retired, so you would
not need new_package request, just change request.

Please check the license tag so it correctly follow reality:
GPL (v2 or later) (with incorrect FSF address)
----------------------------------------------
metapixel-1.0.2/convert.c
metapixel-1.0.2/getopt.c
metapixel-1.0.2/getopt.h
metapixel-1.0.2/getopt1.c
metapixel-1.0.2/imagesize.c
metapixel-1.0.2/metapixel.c
metapixel-1.0.2/metapixel.h
metapixel-1.0.2/pools.c
metapixel-1.0.2/pools.h
metapixel-1.0.2/rwimg/readimage.c
metapixel-1.0.2/rwimg/readimage.h
metapixel-1.0.2/rwimg/rwgif.c
metapixel-1.0.2/rwimg/rwgif.h
metapixel-1.0.2/rwimg/rwjpeg.c
metapixel-1.0.2/rwimg/rwjpeg.h
metapixel-1.0.2/rwimg/rwpng.c
metapixel-1.0.2/rwimg/rwpng.h
metapixel-1.0.2/rwimg/writeimage.c
metapixel-1.0.2/rwimg/writeimage.h
metapixel-1.0.2/vector.c
metapixel-1.0.2/vector.h
metapixel-1.0.2/zoom.c
metapixel-1.0.2/zoom.h

LGPL (v2 or later) (with incorrect FSF address)
-----------------------------------------------
metapixel-1.0.2/allocator.c
metapixel-1.0.2/allocator.h
metapixel-1.0.2/lispreader.c
metapixel-1.0.2/lispreader.h

You may even wont to contact upstream so they update their license file.