https://bugzilla.redhat.com/show_bug.cgi?id=2183400
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |maxwell@gtmx.me Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |maxwell@gtmx.me Flags| |fedora-review?
--- Comment #1 from Maxwell G maxwell@gtmx.me --- I'll take this review :). Here are some initial comments:
%gometa -f
Remove the `-f` flag and just use plain `%gometa`. The `-f` flag disables building/testing the package on i386 which we don't want in this case. We're only using this flag for new packages that don't have dependents. containerd is still built for i386.
The package only contains a btrfs-test binary which isn't useful for end users, so I wouldn't ship it. You'll have to add
``` %global debug_package %{nil} ```
to the beginning of the specfile (right above %bcond_without check is a standard place, but it doesn't particularly matter) and make the changes listed below.
%build for cmd in cmd/* ; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done
Remove the entire %build section. We don't want to ship the btrfs-test binary.
%install %gopkginstall install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
Remove the two install invocations. We're not installing any binaries.
%files %license LICENSE %doc README.md %{_bindir}/*
Remove this %files section.