Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=455067
--- Comment #6 from Pavel Alexeev pahan@hubbitus.spb.su 2008-08-24 20:26:41 EDT --- (In reply to comment #4)
For 2.0.2-0:
- Release number
- The minimum number which can be used for Release number is 1. 0 is used only for pre-release tarballs:
Hmmm, I'm lose sight of. I assume now release shoud be 2 (1 should have been previous).
- License
- As far as I verified the source code, the license tag should be "GPLv2+".
Official site ( http://ferm.foo-projects.org/) says: "Licensed under the GPLv2"
- rpmlint issue
ferm.noarch: W: incoherent-version-in-changelog 2.0.2 2.0.2-0.fc10
Ok, done.
- Macros usage consistency
- When using { on macros, please use { for all macros (except for some cases) consistently. You use %{_mandir} and %_sbindir , for example.
%_sbindir replaced by %{_sbindir} Is there any guidelines about it or is it only by the aesthetic considerations?
- Documents
- Please also add the following files to %doc.
NEWS
Done.
(In reply to comment #3)
(In reply to comment #2)
- "system/firewalls" is not a standard Group (please refer to $ rpmlint -I non-standard-group
Thanks. I'm change it to "Applications/System". But another question is why rpmlint was silent??
- On my system rpmlint warned about this.s
You are using stable version of the rpmlint or rawhide? May be I can tune warning level somewhere?
$ rpm -q rpmlint rpmlint-0.84-2.fc9.noarch
- "Requires: perl" is redundant. Usually perl (module) related dependencies are automatically detected and added to rebuilt binary rpms by rpmbuild.
I suppose that do not requires external perl modules. Requires: perl removed. But I can't understand how it will be detected? It is based on standard Makefile, nor perl buildsystem.
- This is detected by /usr/lib/rpm/perl.req. Try
...
Thank you very much for the explanation.