Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530204
--- Comment #4 from Jeroen van Meeuwen kanarip@kanarip.com 2009-10-25 07:42:25 EDT --- (In reply to comment #3)
Well, I have not checked your latest srpm yet, however: (In reply to comment #1)
- License
- MIT.
No, this is BSD, not MIT, sorry...
No problem; corrected in the new SPEC/SRPM.
(In reply to comment #2)
(In reply to comment #1)
- Test
- As this gem file contains test/ directory, please add %check section and execute some tests there.
Two out of three tests require rubygem-hpricot, which is not in Fedora yet. Enabled the other test though.
- rubygem-hpricot is already in Fedora and actually the maintainer is me (if upgrade or bug fix is needed, please file a bug)
Ha! How did I miss this! ;-) Enlisted myself as co-maintainer if you don't mind. Made it a BuildRequirement and enabled all three tests separately (as one of them would still fail but I want the output of all three in the build logs).
New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-hawler.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-hawler-0.3-4.fc12.src.rpm