Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: viewmtn - Web interface for Monotone version control system
https://bugzilla.redhat.com/show_bug.cgi?id=435842
thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.moschny@gmx.de
------- Additional Comments From thomas.moschny@gmx.de 2008-03-13 06:56 EST ------- Some remarks:
- There's a typo in viemtn/__init__.py, generated from the specfile: "from viewmtn import assemble_urls, web" instead of "from import viewmtn assemble_urls, web".
- Why is viewmtn/__init__.py generated in the specfile? Could be a %source.
- Shouldn't the symlink logic for the user_config not be just the other way round?
/usr/lib/python2.5/site-packages/viewmtn/user_config.py -> /etc/viewmtn.conf.py instead of /etc/viewmtn.conf.py -> /usr/lib/python2.5/site-packages/viewmtn/user_config.py
This way, one could customize the db location via editing the file in /etc, which currently doesn't work.
- What about interoperability with the 'monotone-server packet?' Would be really nice if displaying the db from that package would work out of the box. (Would need changing/relaxing the permissions of the server db a bit.)
- Maybe webpy should go into its own package and viewmtn depend on that.
- The inevitable rpmlint output:
viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/web/__init__.py 0644 viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/viewmtn.py 0644 viewmtn.noarch: E: non-standard-uid /var/cache/viewmtn-graph apache viewmtn.noarch: E: non-standard-gid /var/cache/viewmtn-graph apache viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/fdo/xdgbasedir.py 0644 viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/mk2.py 0644 viewmtn.noarch: W: symlink-should-be-relative /etc/viewmtn.conf.py /usr/lib/python2.5/site-packages/viewmtn/user_config.py viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/fdo/sharedmimeinfo.py 0644 viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/fdo/icontheme.py 0644 viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/tests.py 0644 viewmtn.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/viewmtn/genproxy.py 0644