Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Slony-1 (postgresql-slony-engine)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199154
ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
------- Additional Comments From ruben@rubenkerkhof.com 2007-06-30 15:26 EST ------- Ok, here we go
- The upstream project is called Slony-I. Why is the package called postgresql-slony1-engine?
- Source0 is not available. http://main.slony.info/downloads/1.2/source/slony1-1.2.0.tar.bz2 seems to be the right one (there's a doc tarball as well)
- Errors during build: chmod -R 644 doc/Makefile doc/adminguide doc/concept doc/howto doc/implementation doc/support chmod: cannot access `doc/adminguide/schemadoc.xml': Permission denied chmod: cannot access `doc/adminguide/usingslonik.sgml': Permission denied chmod: cannot access `doc/adminguide/slonyupgrade.sgml': Permission denied etc... the chmod -R 644 sets drw-r--r-- permissions on the directory, so you can't reach the files in it. Maybe you can use something like find doc/ -type f -exec chmod 600 {} ;
- It also seems to be missing yacc: Missing yacc parser.y parser.c
- Since postgresql_autodoc is now available, maybe you can add it to the BuildRequires - I'd skip the %if %docs and %if %perltools. It's only one perl module, and that cleans up the specfile a lot.
- This isn't necessary: # Strip out -ffast-math from CFLAGS....
CFLAGS=`echo $CFLAGS|xargs -n 1|grep -v ffast-math|xargs -n 100` There is no -ffast-math in %{optflags}
- %configure --includedir %{_includedir}/pgsql --with-pgconfigdir=%{_bindir} is probably not necessary either, pg_config is in the path, and will tell configure where the libs and headers are
- Remove this line: #%define pg_version %(rpm -qv postgresql-devel|head -n 1|awk -F '-' '{print $3}') - and this one: %define prefix /usr, they're not used
This won't work: if [ -d /etc/rc.d/init.d ] then install -d %{buildroot}/etc/rc.d/init.d fi
You check if the directory exists, and if it exists, you create it. and replace that path with %{_initrddir}. If you add initscripts as a requirement, that directory should be there
Good luck!