Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886908
Simone Caronni negativo17@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #3 from Simone Caronni negativo17@gmail.com --- As in xonotic review:
1) I would prefer also to have the various tags (Name: Release: etc.) and values separated by some tab if possible, but this is only my opinion.
2) Macros should not be used unless necessary [1], I think %{__rm}, %{__install}, %{__mkdir_p} and %{__sed} should be removed.
3) What are the comments from line 31 to 39 used for?
[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
Thanks, --Simone