Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: PyAmanith - Python bindings for Amanith
https://bugzilla.redhat.com/show_bug.cgi?id=399951
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From tibbs@math.uh.edu 2008-01-18 22:19 EST ------- It occurs to me that this might have been submitted as a dependency for Frets on Fire, but I'll go ahead and review it and you can do with it what you will.
This failed to build for me in rawhide due to the .egg-info thing. I fixed that (and I'll just assume that it's been fixed for the remainder of this review) and got the following rpmlint complaint:
PyAmanith.x86_64: E: non-standard-executable-perm /usr/lib64/python2.5/site-packages/_amanith.so 0775 which is a little weird, I'll admit. A chmod or %attr should get rid if it, though.
There's a copying file in the tarball that should make it into the package, especially since it's the only place I found with the text of the GPL exception the package is licensed under.
* source files match upstream: a16a3a8379246549008c514fb549337700ea5a17ba524187f8213e92f9a966f0 PyAmanith-0.3.35.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. X license text not included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. X rpmlint has a valid complaint. * final provides and requires are sane: _amanith.so()(64bit) PyAmanith = 0.3.35-1.fc9 = libamanith.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpython2.5.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) python(abi) = 2.5
* %check is not present; no test suite upstream. rawhide is screwed enough at the moment that I can't test it manually. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files.