Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-SimpleDBI - Asynchronous non-blocking DBI calls in POE made simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204439
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-09-02 16:14 EST ------- Another standard spanspec-generated Perl package; no surprises here.
* source files match upstream: a1c287b5297ceef014910722f3ce8b3f POE-Component-SimpleDBI-1.12.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::SimpleDBI) = 1.12 perl(POE::Component::SimpleDBI::SubProcess) = 1.09 perl-POE-Component-SimpleDBI = 1.12-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DBI) perl(Error) perl(POE) perl(POE::Filter::Line) perl(POE::Filter::Reference) perl(POE::Session) perl(POE::Wheel::Run) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=1, Tests=2, 0 wallclock secs ( 0.10 cusr + 0.04 csys = 0.14 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings.
APPROVED