Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809503
Lukáš Zapletal lzap@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lzap@redhat.com AssignedTo|nobody@fedoraproject.org |lzap@redhat.com
--- Comment #1 from Lukáš Zapletal lzap@redhat.com 2012-04-13 05:36:44 EDT --- Hi Devan,
taking for review.
MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1]
[lzap@lzapx Download]$ rpmlint liquibase-2.0.3-5.fc18.noarch.rpm liquibase.noarch: W: name-repeated-in-summary C Liquibase liquibase.noarch: W: spelling-error %description -l en_US trackable -> traceable, tractable, track able liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/liquibase-ext-change.iml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/samples.iml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/liquibase-ext-changewithnestedtags.iml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/SampleGrandChild.java liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/src/main/java/liquibase/ext/samplesqlgenerator/SampleUpdateGenerator.java liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/changelog.txt liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/ChangeWithNestedTags.java liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/pom.xml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/src/main/java/liquibase/ext/changewithnestedtags/SampleChild.java liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-changewithnestedtags/pom.xml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-sqlgenerator/liquibase-ext-sqlgenerator.iml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/pom.xml liquibase.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/liquibase-2.0.3/samples/liquibase-ext-change/src/main/java/liquibase/ext/changesample/SampleChange.java liquibase.noarch: W: no-manual-page-for-binary liquibase 1 packages and 0 specfiles checked; 0 errors, 16 warnings.
[lzap@lzapx Download]$ rpmlint liquibase-2.0.3-5.fc16.src.rpm liquibase.src: W: name-repeated-in-summary C Liquibase liquibase.src: W: spelling-error %description -l en_US trackable -> traceable, tractable, track able liquibase.src: W: invalid-url Source0: liquibase-2.0.3.tar.gz 1 packages and 0 specfiles checked; 0 errors, 3 warnings
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
FIX: The git clone command is missing tag or hash. Your instructions will lead to master/random tarball.
Please consider using generate-tarball script as described here: http://fedoraproject.org/wiki/Packaging:SourceURL
MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7]
http://koji.fedoraproject.org/koji/taskinfo?taskID=3987265
MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18]
Consider generating javadoc and adding -doc package delivering both docs and samples. See the section at https://fedoraproject.org/wiki/Packaging:Java
FIX: All JAR files MUST go into %{_javadir} or a Java-version specific directory %{_javadir}-* as appropriate[1].
Please use the Fedora macro for javadir.
Please consider using build-java-classpath. So instead:
export LIQUIBASE_HOME="/usr/share/java/"
use
CP=$(build-classpath liquibase)
Or consider using wrapper script auto generator from Wrapper Scripts section.
Looks good.