https://bugzilla.redhat.com/show_bug.cgi?id=1419330
--- Comment #10 from sensor.wen@gmail.com ---
[x]: Package is named according to the Package Versioning Guidelines. Note: Git commit should not be included in the release tag if it is the proper released version. And the source url can be written using Git tags. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 25 files have unknown license.
How to fix?
[x]: shebang removing procedure can be improved [x]: ldconfig is redundant [x]: Removing OnlyShowIn is bad. One can submit a request to freedesktop to add a new recognized desktop environment, like: https://bugs.freedesktop.org/show_bug.cgi?id=51258
Need more than a year to solve. add Deepin for OnlyShowIn key: https://bugs.freedesktop.org/show_bug.cgi?id=101878
[-]: It is better to use relative path for symlink.
Absolute path is better. Unless you need to use the dnf --installroot option.
[-]: It is better to separate changelog entries with empty lines. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...