https://bugzilla.redhat.com/show_bug.cgi?id=787713
--- Comment #42 from Ralf Corsepius rc040203@freenet.de --- FWIW: I was about to send patches, right when Alec's patches arrived. Now, I need to sort out this situation out.
First of all, Alec's findings match with mine (Broken spelling, no qhull pkg-config, missing headers, pkg-config wrapper), but I am having difficulties with some details of changes/proposals:
(In reply to comment #40)
The public header files under include are not installed by 'make install' Inline patch to fix: diff -U2 FreeSOLID.spec.ORG FreeSOLID.spec --- FreeSOLID.spec.ORG 2012-07-09 23:59:52.482377610 +0200 +++ FreeSOLID.spec 2012-07-10 00:19:05.470474834 +0200 @@ -74,4 +74,6 @@ %install make install DESTDIR=%{buildroot} +cp -ar include/SOLID include/3D include/config.h \
- %{buildroot}%{_includedir}/%{name}
config.h is an internal autoheader, which must not be installed. All other headers must be installed, otherwise the package doesn't work.
I have a Makefile.am patch pending, but first have to rebase my local version with Martin's latest version
(In reply to comment #33)
Created attachment 596980 [details] Patch free-solid-config to use pkg-config
Convert freesolid-config to use pkg-config according to Ralf's proposal.
I do not understand the first part of the patch (The "On Fedora, changes to prefix and exec-prefix are silently ignored" chunk). AFAIS, there is no behavioral change to the original freesolid-config, which would mean this change would be superflous.
(In reply to comment #41)
Created attachment 597182 [details] Updated FreeSOLID-2.1.1-pkgconfig.patch
Old version provides wrong data (freesolid -> FreeSOLID)
Why "Name: Free Solid" and not "Name: FreeSolid"?