Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=614541
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-07-15 15:37:21 EDT --- Hey Dan. ;)
Some general comments here before a full review:
- Take a look at http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored If you have some more packages to submit and/or wish to do some 'pre reviews' of other pending reviews to show you know the guidelines, that would be great.
- Your spec file should match the package name. Please make sure it's "Django-loki.spec" and not just "loki.spec"
- Please see: https://fedoraproject.org/wiki/Packaging:Python_Eggs about the egg files. You shouldn't ghost them, but should provide them. Also, might check over the main python guidelines: https://fedoraproject.org/wiki/Packaging:Python
Please update those things and I will look at doing a formal review. ;)