Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jna - Pure Java access to native libraries
https://bugzilla.redhat.com/show_bug.cgi?id=436036
------- Additional Comments From konrad@tylerc.org 2008-03-11 16:59 EST ------- (In reply to comment #3)
Well, I am not familiar with java, so I must ask you some question.
- ExcludeArch
- Now "java-devel > 1.6" is provided by java-1.7.0-icedtea for all archs and this should build on all archs.
The ExcludeArch is there from when I was trying to build in koji as dist-f8 and didn't want to hit PPC build hosts. It is a mistake I will remedy.
- By the way now Fedora ships "java-1.6.0-openjdk" and I am not sure which mock tries to use by "BuildRequires: java-devel >= 1.6".
Shouldn't matter I don't think.
- libffi
- From build.log jna uses internall libffi, however now (at least on rawhide) libffi is system-widely provided. Would you patch against jna to use system wide libffi?
Yes.
- Fedora specific compilation flags
- From build.log, Fedora specific compilation flags are not honored.
Will fix.
- debuginfo? strip binaries?
... When Fedora compilation flags are correctly honored, libtestlib.so is created with debug flag "-g", and this will not be stripped as this library is packaged as jar style. - Are there any means to create "debuginfo" rpm for this library? - If not, should this library be stripped or not?
I don't know how this should be handled. I will fix the other problems and then ask the java devel list about this sort of thing.
Thank you for the very thorough feedback!