Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ecore - Event/X abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=442353
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |pertusus@free.fr Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From pertusus@free.fr 2008-05-02 16:12 EST ------- In the configure output there is Ecore_Evas SDL Support.......: no Maybe something is missing from the evas build?
I think it would be better to break a bit the BuildRequires line in more lines, and break at 80 columns (if possible).
2 man pages are without prefix, I think it is bad: /usr/share/man/man3/Idle_Group.3.gz /usr/share/man/man3/X_Window_System_Page.3.gz
I think it would be better to use rm doc/man/man3/todo.3 such that if tere is no such man page, it is detected.
In ecore-x.pc there is an unneeded -L/usr/X11R6/lib, but I don't think it needs to be fixed: it doesn't hurt and it is for static linking which is not possible anyway.
None of these issues are blockers. So
* rpmlint is silent * follow guidelines * free software, license included * match upstream: a66df2b5f0b1a6abc47bb50bf2b26846 ecore-0.9.9.042.tar.bz2 * library correctly packaged * %files section right
APPROVED
Please consider my comments before importing.