Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464051
Orcan 'oget' Ogetbil orcanbahri@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@yahoo.com AssignedTo|nobody@fedoraproject.org |orcanbahri@yahoo.com Flag| |fedora-review?
--- Comment #3 from Orcan 'oget' Ogetbil orcanbahri@yahoo.com 2008-11-07 23:20:44 EDT --- This one is almost perfect. There are few little things to go through.
* URL has a typo
* Same subtleties apply for the license of this package as for the projectM-pulseaudio. "GPLv2+ and MIT" is fine but it would be good if we get a confirmation from upstream.
* I don't see any .la files built. You should remove that line.
* For the desktop file, please add Encoding=UTF-8 Terminal=false You use the same icon in the desktop file that you use for projectM-pulseaudio. You can require projectM-pulseaudio on this package, but that's not a nice solution. I think the best solution is renaming the icon file for this package.