Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: <libtune> - <standard API to access the kernel tunables>
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007
------- Additional Comments From jwboyer@jdub.homelinux.org 2006-10-15 16:24 EST ------- A few comments:
1) The package fails to build on rawhide due to some unpackaged files:
Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/libtune-0.10-1-root-jwboyer error: Installed (but unpackaged) file(s) found: /var/lib/tundb/tundb_distro /var/lib/tundb/tundb_kernel
RPM build errors: Installed (but unpackaged) file(s) found: /var/lib/tundb/tundb_distro /var/lib/tundb/tundb_kernel
2) While a generic spec file is probably a great idea for the upstream project, having tunables-data and tunables-distro packages for kernels that aren't part of the current Fedora distro (SLES, RHEL, older FC) doesn't make much sense from and Extras viewpoint.
Is it possible to generate tunables-data and tunables-distro packages at RPM build time? If so, that would allow a very generic spec file that would work for any kernel or distro the RPMs were built on.
3) If the tunables-data and tunables-distro packages are very dependent upon a specific version of a kernel, they should actually Requires: that particular kernel version. This might quickly become cumbersome for the development tree, as new kernels are released on almost a daily basis.
4) The location of the of the libtune_* scripts does not comply with the FHS. /var/lib/ is to be used for data and state information. The scripts should probably go into /usr/share/libtune/bin/ or /usr/share/tundb/bin/. The same applies to the doc directory.