Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ext3grep - Recovery tool for ext3 filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=448745
bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |bdpepple@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From bdpepple@gmail.com 2008-05-28 19:55 EST ------- MD5Sum: aabd3b85e5862cddc284a37f300df186 ext3grep-0.6.0.tar.gz
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Rpmlint produces no warnings or errors * Package builds fine in koji. * Package installs and uninstalls cleanly
Minor (non-blocker): * you should package the LICENSE.GPL2 file.
+1 Approved