https://bugzilla.redhat.com/show_bug.cgi?id=2169846
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) |
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- Did you try building this in mock? I get:
ERROR: %pyproject_check_import only works when %pyproject_save_files is used
Try this:
%install %pyproject_install %pyproject_save_files moddb
And this:
%files -n python3-moddb -f %{pyproject_files} %doc README.md
In this case, you don’t even need “%license LICENSE” because it is properly handled in pyproject_files. There are some packages where that isn’t the case (depending mostly on which build backend is used, e.g. setuptools/hatchling/flit-core/poetry), so it’s best to check:
$ rpm -qL -p python3-moddb-0.8.1-1.fc39.noarch.rpm /usr/lib/python3.11/site-packages/moddb-0.8.1.dist-info/LICENSE
You don’t really need to use %pyproject_check_import if you are running the tests with %pytest (and the test coverage is decent), although it’s fairly harmless to have both.
The PyPI sdist doesn’t have the tests in it, so you are going to need to package from the GitHub archive:
https://github.com/ClementJ18/moddb/archive/v%%7Bversion%7D/moddb-%%7Bversio...
…in order to run them. You are also going to need some of the BuildRequires in requirements-dev.txt, such as pytest. Don’t depend on black or flakeheaven (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters), or on the sphinx packages if you are not building the documentation. Note that %pyproject_buildrequires *can* consume requirements text files.