[Bug 1170374] Review Request: yum-plugin-needs-restarting - YUM plugin for listing processes using old files after upgrade

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1170374

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Miroslav Suchý  ---
1) I'm not sure if it is worth the work to continue adding something for yum. I
would focus work on some plugin for DNF instead.

2) There is much better plugin (for DNF) called tracer. See bug 1158629

And if you want to learn something:

* %defattr(-, root, root)
This is default and not needed since rpm 4.2

* %{__python} -c "import compileall;
compileall.compile_dir('%{buildroot}/%pluginhome', 1)"
rpm do that automatically, no need to do that.

* rm -rf %{buildroot}
not needed: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

* you should preserve timestamps and use "cp -a"

* license should be marked using %license macro
  %license COPYING

* do not enumerate all extension and just use:
  %{pluginhome}/needs-restarting.py*