Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cobbler
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192311
------- Additional Comments From jpmahowald@gmail.com 2006-07-05 00:04 EST ------- Now that we have some changes please increment the release every time you make some changes. It allows for tracking of stuff via %changelog and ensures we all have the latest version. Different packages circulating with the same version and release is bad.
Don't bother with defining your own macros for name, version, and release, rpm does that.
Typically the URL points at an informational page. Does one exist? Is your packages the only release?
Seems INSTALLED_FILES doesn't list directories, so don't use that. http://fedoraproject.org/wiki/Packaging/Python (this page has some other hints for python packaging as well)