Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=515898
--- Comment #7 from David Sommerseth davids@redhat.com 2009-09-23 04:59:49 EDT --- (In reply to comment #6)
I see you removed the NEEDSPONSOR blocker, but I can't find your name in the account system. It's not "davids" and a search on "Sommerseth" finds nothing.
Ahh sorry! I thought that Jussi Lehtola forgot to do that when answering. My mistake!
What's your FAS ID?
It should be dsommers
I downloaded and unpacked the src.rpm linked above, but it doesn't seem to match the spec file linked above. Whenever you make a change to a package under review, you should increase Release:, generate a new package and update both that and the spec file. Otherwise it quickly becomes difficult for any prospective review to keep things straight. There are far more submissions than reviewers, so making it difficult for reviewers is not a good idea.
Again, I'm sorry for making a mess here.
Anyhow! A new release if imapfilter has surfaced, so I've updated spec files and built a new src.rpm. Hopefully things are more consistent now.
Spec URL: http://people.redhat.com/dsommers/imapfilter/imapfilter.spec SRPM URL: http://people.redhat.com/dsommers/imapfilter/imapfilter-2.0.11-1.fc11.src.rp...
You made me aware of rpmlint in another bz ... so I did run rpmlint on spec file, src.rpm and binary rpms. But there is one thing which I'm not able to fix ...
imapfilter.src:25: W: configure-without-libdir-spec imapfilter.spec:25: W: configure-without-libdir-spec
I believe this is because the configure script is not autotools based. I've made a comment about it in the .spec file. I did however reduce this warning to only appear once in each file and not twice, by renaming the ./configure script.