https://bugzilla.redhat.com/show_bug.cgi?id=817303
--- Comment #8 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to comment #5)
About [ -f package2.xml ] || mv package.xml package2.xml mv package2.xml %{pear_name}-%{version}/%{name}.xml
This is a old hack (yes it works) to ensure than package v2 is used.
I often use
# package.xml is version 2.0 mv package.xml %{pear_name}-%{version}/%{name}.xml
This is not an issue, but make the spec simpler to read.
I will make this change along with the review issue changes. I like what you use much better than the old hack (I was just copying what I thought was the standard).
About %clean As you have clean EL-5 stuff (Buildroot, %defattr) you should also remove the %clean section and the rm -rf %{buildroot} in %install
Will do
I will prefer to move documentation to correct location by fixing the package.xml (temporary hack waiting for upstream fix, see bug #823041)
Will do
In fact you don't need to requires (nor buildrequires) php-pear(PEAR), the PEAR classes are not used, only the installer. But the Guildelines says you must.. so keep it (I will probably propose a minor update to the PHP Guidelines)
BuildRequires: php-pear >= 1:1.4.9-1.2 BuildRequires: php-pear(PEAR)
The first could be removed (no more older version, even in EPEL) and is a duplicate of the second.
I will remove "BuildRequires: php-pear >= 1:1.4.9-1.2" (I was just copying what I thought was the standard). As you mentioned, I will keep "BuildRequires: php-pear(PEAR)" and "Requires: php-pear(PEAR)" for now per the guidelines.
Please confirm your fas account (as we have 6 packages approved + this one near to be, I will soon sponsor you).
FAS account: siwinski
we have 6 packages approved
All of my php-symfony2-* packages used the same template so I will need to update and repost them with these changes as well.