Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537587
--- Comment #72 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-20 13:36:39 EST --- Checked 3.9.0-1.1
* %setup - "%setup -q -n %{name}-3.9.0" can be simplified as "%setup -q"
! Comments - Remove comments like "# webui - disabled"
* Macros - Use %{_datadir} instead of %{_usr}/share https://fedoraproject.org/wiki/Packaging/RPMMacros
- And use %{_sysconfdir} instead of /etc .
* file splitting - %_bindir/dspam-front shell script is not useful without %_bindir/dspam (as its contents shows)
* %attr - "%attr(0755,root,root)" for directory, "%attr(0644,root,root)" for files, and "%attr(-,root,root)" are default attribute and these should be removed.
* Duplicate %files entry ------------------------------------------------------------------ %dir %attr(0755,root,root) %{_usr}/share/dspam-webui/templates %attr(-,root,root) %{_usr}/share/dspam-webui/* ------------------------------------------------------------------ - Note that %{_usr}/share/dspam-webui/* contains %{_usr}/share/dspam-webui/templates , and so this causes the following warning from rpmbuild: ------------------------------------------------------------------ 1142 Processing files: dspam-web-3.9.0-1.1.fc13.i686 1143 warning: File listed twice: /usr/share/dspam-webui/templates ------------------------------------------------------------------