[Bug 1756899] Review Request: upt - Universal Packaging Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1756899

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #2 from Robert-André Mauchin  ---
@J. Scheurich:

(In reply to J. Scheurich from comment #1)
> This is only a informal review, i am not in the packager group 8-(
>
> $ fedora-review -n upt
> INFO: Processing local files: upt
> ...
> INFO: Build completed
> INFO: Installing built package(s)
> INFO: Install command returned error code 30
>
> $ more /home/mufti/review-upt/review.txt
> ...
> ERROR: Command failed:
>  # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
> --releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local
> --disableplugin=spacewalk install
> /home/mufti/review-upt/resultsupt-0.10.3-1.fc32.noarch.rpm
> --setopt=tsflags=nocontexts

Search for errors in root.log to see why the installation has failed (probably
missing python-spdx-lookup)

- This should be marked as okay:

[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should

- Why did you mark this as Invalid? AFAIK the packager did not include extra
license files.

[!]: Package does not include license text files separate from upstream.
     provide egg info.

Also I sent you a new mail regarding sponsorship, please reply to it (it may be
stuck in SPAM).

(In reply to Jeremy Bertozzi from comment #0)
> Spec URL:
> https://raw.githubusercontent.com/jbertozzi/copr-build-upt/master/upt.spec
> SRPM URL:
> https://github.com/jbertozzi/copr-build-upt/raw/master/SRPMS/upt-0.10.3-1.
> fc30.src.rpm
>
> Description: A unified CLI tool that converts a package from a
> language-specific package manager (such as PyPI or NPM) to an almost
> ready-to-use package for Free Unix-based operating systems (such as a
> GNU/Linux distribution or *BSD).
>
> FAS username: jbertozzi
>
> I am looking for a sponsor for this package, and its dependencies.

Based on J. Scheurich review, I approve this package. You still need to find a
sponsor, see
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group